[U-Boot] [PATCH 4/8] x86: fsp: Enlarge the size of malloc() pool before relocation

[Bin Meng]

Hi Simon,

On Tue, Aug 18, 2015 at 10:00 AM, Simon Glass <sjg at chromium.org> wrote:
> Hi Bin,
>
> On 15 August 2015 at 01:07, Bin Meng <bmeng.cn at gmail.com> wrote:
>> After fsp_init() returns, the stack has already been switched to a
>> place within system memory as defined by CONFIG_FSP_TEMP_RAM_ADDR.
>> Enlarge the size of malloc() pool before relocation since we have
>> plenty of memory now.
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>> ---
>>
>>  arch/x86/Kconfig              | 7 +++++++
>>  arch/x86/cpu/start.S          | 8 ++++++++
>>  arch/x86/lib/fsp/fsp_common.c | 6 +++++-
>>  3 files changed, 20 insertions(+), 1 deletion(-)
>
> Can you please explain a bit why this patch is needed? Wouldn't it be
> better to avoid needing so much memory?
>

This is because even with pci-uclass change, the memory is still not
enough on Crown Bay to support PCI UART as the UART is behind two
bridges (at best), or five bridges (at worst).

Anyway I change this not only for Crown Bay. It's a "feature" that FSP
provides since it already switches to a new stack which is using
system memory where the size is not a problem.

Regards,
Bin