[U-Boot] [RESEND PATCH v6] mtd/nand/ubi: assortment of alignment fixes

Simon Glass sjg at chromium.org
Tue Aug 18 17:54:20 CEST 2015


Hi,

On 18 August 2015 at 09:49, Scott Wood <scottwood at freescale.com> wrote:
> On Tue, 2015-08-18 at 06:44 -0600, Simon Glass wrote:
>> Hi Marcel,
>>
>> On 18 August 2015 at 05:06, Marcel Ziswiler <marcel at ziswiler.com> wrote:
>> >
>> > diff --git a/include/common.h b/include/common.h
>> > index c48e5bc..c12f402 100644
>> > --- a/include/common.h
>> > +++ b/include/common.h
>> > @@ -1060,6 +1060,15 @@ int cpu_release(int nr, int argc, char * const
>> > argv[]);
>> >  #define DEFINE_CACHE_ALIGN_BUFFER(type, name, size)                    \
>> >         DEFINE_ALIGN_BUFFER(type, name, size, ARCH_DMA_MINALIGN)
>> >
>> > +#ifndef __ASSEMBLY__
>> > +#include <malloc.h>
>> > +
>> > +static inline void *malloc_cache_aligned(size_t size)
>> > +{
>> > +       return memalign(ARCH_DMA_MINALIGN, ALIGN(size,
>> > ARCH_DMA_MINALIGN));
>> > +}
>> > +#endif
>>
>> Should this go in malloc.h?
>
> I previously asked for it to not go into malloc.h, in order to not mix
> upstream dlmalloc stuff with U-Boot things.

That's fine. It's a bit of a mess in there.

Regards,
Simon


More information about the U-Boot mailing list