[U-Boot] [PATCH v2 05/12] x86: queensbay: Move unprotect_spi_flash() to arch_misc_init()

Bin Meng bmeng.cn at gmail.com
Thu Aug 20 15:40:21 CEST 2015


With dm pci conversion, pci config read/write in unprotect_spi_flash()
silently fails as at that time dm pci is not ready and bus enumeration
is not done yet. Actually we don't need to do this in that early phase,
hence we delay this call to arch_misc_init().

Signed-off-by: Bin Meng <bmeng.cn at gmail.com>

---
Simon's patch (http://patchwork.ozlabs.org/patch/506810/) should fix
this pci config read/write silently failure issue. But it does not do
any harm we move this to some late phase.

Changes in v2: None

 arch/x86/cpu/queensbay/tnc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/cpu/queensbay/tnc.c b/arch/x86/cpu/queensbay/tnc.c
index c465642..9682cff 100644
--- a/arch/x86/cpu/queensbay/tnc.c
+++ b/arch/x86/cpu/queensbay/tnc.c
@@ -36,8 +36,6 @@ int arch_cpu_init(void)
 	if (ret)
 		return ret;
 
-	unprotect_spi_flash();
-
 	return 0;
 }
 
@@ -80,5 +78,7 @@ void cpu_irq_init(void)
 
 int arch_misc_init(void)
 {
+	unprotect_spi_flash();
+
 	return pirq_init();
 }
-- 
1.8.2.1



More information about the U-Boot mailing list