[U-Boot] [PATCH 3/5] arm: tegra30: video: integrate display driver for t30

[Stephen Warren]

On 08/20/2015 05:29 AM, Marcel Ziswiler wrote:
> On popular request make the display driver from T20 work on T30 as
> well. Turned out to be quite straight forward. However a few notes
> about some things encountered during porting: Of course the T30 device
> tree was completely missing host1x as well as PWM support but it turns
> out this can simply be copied from T20 supplementing some tegra30-
> compatible nodes here and there while comparing it with the Linux
> device tree includes.

Hopefully the process was to copy the Linux Tegra30 DT verbatim? That's 
far more likely to yield a correct DT than copying the Tegra20 DT to 
Tegra30 and then patching it until it works. If this DT doesn't exactly 
match the Linux kernel, this needs to be fixed.

> diff --git a/arch/arm/mach-tegra/tegra30/Makefile b/arch/arm/mach-tegra/tegra30/Makefile

> -obj-$(CONFIG_SPL_BUILD) += cpu.o
> +ifdef CONFIG_SPL_BUILD
> +obj-y	+= cpu.o


I don't think there's any need to edit the cpu.o line. While you can 
move it into the ifdef like that, I don't see a need.

> diff --git a/arch/arm/mach-tegra/tegra30/display.c b/arch/arm/mach-tegra/tegra30/display.c

I didn't review this file in detail; I'll leave that to Thierry since he 
knows the display HW.

However, one question: Is this file a complete cut/paste of 
tegra20/display.c, or does it just replace some parts of it? Hopefully 
this patch doesn't simply duplicate the whole driver?