[U-Boot] [PATCH] i2c: adding driver for pxa27x, pxa3xx, pxa25x

[Andrew Ruder]

On Wed, Aug 12, 2015 at 09:34:14PM +0200, Marek Vasut wrote:
> On Wednesday, August 12, 2015 at 08:43:52 PM, Andrew Ruder wrote:
> > +#if !defined(CONFIG_SYS_PXA_STD_I2C_SPEED)
> > +#define CONFIG_SYS_PXA_STD_I2C_SPEED 100000
> > +#endif
> > +
> > +#if !defined(CONFIG_SYS_PXA_STD_I2C_SLAVE)
> > +#define CONFIG_SYS_PXA_STD_I2C_SLAVE 1
> > +#endif
> > +
> > +#if !defined(CONFIG_SYS_PXA_PWR_I2C_SPEED)
> > +#define CONFIG_SYS_PXA_PWR_I2C_SPEED 40000
> > +#endif
> > +
> > +#if !defined(CONFIG_SYS_PXA_PWR_I2C_SLAVE)
> > +#define CONFIG_SYS_PXA_PWR_I2C_SLAVE 1
> > +#endif
> 
> Please remove all this stuff, it's only going to hide bugs.

Hide in what way?  Just require that ports define them when enabling the
i2c driver?  ... or don't make it externally configurable?

Thanks,
Andrew