[U-Boot] [PATCH v4 1/4] bitops: introduce BIT() definition

Marek Vasut marex at denx.de
Fri Aug 21 21:29:41 CEST 2015


On Friday, August 21, 2015 at 09:26:41 PM, Michael Heimpold wrote:
> Hi,
> 
> Am Freitag, 21. August 2015, 19:01:56 schrieb Heiko Schocher:
> > introduce BIT() definition, used in at91_udc gadget
> > driver.
> > 
> > Signed-off-by: Heiko Schocher <hs at denx.de>
> > 
> > ---
> > 
> > Changes in v4: None
> > Changes in v3:
> > - new in v3
> > 
> > Changes in v2: None
> > 
> >  include/linux/bitops.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/include/linux/bitops.h b/include/linux/bitops.h
> > index e724310..7d30ace 100644
> > --- a/include/linux/bitops.h
> > +++ b/include/linux/bitops.h
> > @@ -3,6 +3,8 @@
> > 
> >  #include <asm/types.h>
> > 
> > +#define BIT(nr)		(1UL << (nr))
> > +
> 
> JFYI, a few months ago, Wolfgang Denk NAKed a similar patch:
> http://lists.denx.de/pipermail/u-boot/2014-February/173669.html
> 
> But I don't know whether this still stands.

Linux also uses this BIT() macro, I think we should just run with it.

Best regards,
Marek Vasut


More information about the U-Boot mailing list