[U-Boot] [PATCH v3 9/9] dfu: tftp: Kconfig: Enable DFU_TFTP support on the am335x_boneblack_defconfig

[Lukasz Majewski]

On Tue, 18 Aug 2015 19:31:03 -0500
Joe Hershberger <joe.hershberger at gmail.com> wrote:

> Hi Lukasz,
> 
> On Tue, Aug 18, 2015 at 4:28 PM, Lukasz Majewski
> <l.majewski at majess.pl> wrote:
> > On Tue, 18 Aug 2015 10:12:46 -0500
> > Joe Hershberger <joe.hershberger at gmail.com> wrote:
> >
> >> Hi Lukasz,
> >>
> >> On Thu, Aug 13, 2015 at 6:02 PM, Lukasz Majewski
> >> <l.majewski at majess.pl> wrote:
> >> > This commit enables support for DFU_TFTP on the am335x bone black
> >> > device.
> >> >
> >> > Signed-off-by: Lukasz Majewski <l.majewski at majess.pl>
> >> >
> >> > ---
> >> > Changes for v3:
> >> > - New patch
> >> > ---
> >> >  configs/am335x_boneblack_defconfig | 1 +
> >> >  1 file changed, 1 insertion(+)
> >> >
> >> > diff --git a/configs/am335x_boneblack_defconfig
> >> > b/configs/am335x_boneblack_defconfig index 60339c8..f1ff65f
> >> > 100644 --- a/configs/am335x_boneblack_defconfig
> >> > +++ b/configs/am335x_boneblack_defconfig
> >> > @@ -8,3 +8,4 @@ CONFIG_SYS_EXTRA_OPTIONS="EMMC_BOOT"
> >> >  # CONFIG_CMD_FLASH is not set
> >> >  # CONFIG_CMD_SETEXPR is not set
> >> >  CONFIG_SPI_FLASH=y
> >> > +CONFIG_DFU_TFTP=y
> >>
> >> This looks like you simply added this option to the end of the
> >> list.
> >
> > Yes, exactly.
> >
> >> You should run this through "make savedefconfig" so we don't
> >> generate churn on future config changes.
> >
> > Please correct me if I'm wrong. I should run make savedefconfig on
> > the proper .config. Then mv
> > defconfig ./configs/am335x_boneblack_defconfig and commit changes?
> 
> You should add it (as you did is fine), then run 'make
> am335x_boneblack_defconfig', then run 'make savedefconfig', then 'mv
> defconfig configs/am335x_boneblack_defconfig'. I think this is the
> process you were describing but I wanted to be explicit.

The result of the above is the same as the patch I've prepared by
simply adding proper config by hand. Just pure luck :-)

> 
> Cheers,
> -Joe

Best regards,
Lukasz Majewski
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150822/56e90b1d/attachment.sig>