[U-Boot] [PATCH v2 3/3] buildman: Improve the config comparison feature

[Simon Glass]

Hi Joe,

On 21 August 2015 at 15:14, Joe Hershberger <joe.hershberger at gmail.com> wrote:
> Hi Simon,
>
> On Tue, Aug 18, 2015 at 11:35 PM, Simon Glass <sjg at chromium.org> wrote:
>> At present buildman can compare configurations between commits but the
>> feature is less useful than it could be. There is no summary by architecture
>> and changes are not reported on a per-board basis.
>>
>> Correct these deficiencies so that it is possible to see exactly what is
>> changing for any number of boards.
>>
>> Note that 'buildman -b <branch> -C' is recommended for any build where you
>> will be comparing configuration. Without -C the correct configuration will
>> not be reported since changes will often not be picked up.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>
> This is awesome! Thanks for doing this!
>
> I'm a bit surprised there is commented-out code at the bottom of this
> patch, but it's just a tool, so...

Er, yes I should fix that. I doubt anyone other than me will want to debug this.

>
> Reviewed-by: Joe Hershberger <joe.hershberger at ni.com>
>
> Thanks,
> -Joe

Regards,
Simon