[U-Boot] [PATCH 0/8] dm: rockchip: Enable booting from MMC

[Simon Glass]

Hi Sjoerd,

On 16 August 2015 at 06:01, Sjoerd Simons <sjoerd.simons at collabora.co.uk> wrote:
>
> This patchset allows u-boot on RK3288 device to load and boot kernels
> from MMC using the standard distro boot commands. Patchset is on top of
> the rockchip-working branch of u-boot dm
>
> There are some small oddities with the support:
> - Linux crashes when try to use the FDT if it's re-allocated to memory
>   locations above 512MB. So fdt_high is set to ensure it stays below
>   that.
> - This SoC seems sensitive to the order in which the caches are
>   disabled, when disabling the i-cache before the d-cache starting linux
>   fails (unsure if it fails before or after jumping to linux though)
>
> To fix the latter ``arm: Turn of d-cache before i-cache'' changes the
> ordering in the general v7 code. However i have not tested this yet on
> other device, so it may well need to be handled in rockchip specific
> code.
>
> Tested on a Radxa Rock 2 with square baseboard, booting from SD card. I
> haven't tested eMMC yet however i suspect the SPL will need
> modifications there to load u-boot from eMMC rather then SD (which has
> index 0) ideally by detecting where the SPL itself got loaded from.

This series works well for me. I'm hoping to be able to resend my
rockchip series at the end of this coming week and potentially apply
it the week after. Since your series fixes up the Rockchip to actually
boot a kernel I'd like to bring this in also.

I'll reply to each patch - mostly I just have nits so I have acked
those where I don't have significant comments.

>
>
> Sjoerd Simons (8):
>   doc: Fix reference to Rock pro when Rock 2 is meant
>   mmc: Probe DM based mmc devices in u-boot
>   rockchip: Disable sdio mmc slot on rk3288-firefly
>   rockchip: Turn off CONFIG_SPL_LED_SUPPORT for firefly
>   rockchip: Add config_distro_bootcmd support
>   arm: Turn of d-cache before i-cache
>   rockchip: Drop first 32kb of zeros from the rksd image type
>   rockchip: Update todo in README.rockchip
>
>  arch/arm/cpu/armv7/cpu.c         | 15 +++++++++------
>  arch/arm/dts/rk3288-firefly.dtsi |  2 +-
>  doc/README.rockchip              |  9 ++++-----
>  drivers/mmc/mmc.c                | 32 ++++++++++++++++++++++++++++----
>  include/configs/firefly-rk3288.h |  1 -
>  include/configs/rk3288_common.h  | 21 +++++++++++++++++++++
>  tools/rksd.c                     |  9 ++-------
>  7 files changed, 65 insertions(+), 24 deletions(-)
>
> --
> 2.5.0
>

Regards,
Simon