[U-Boot] [RFC PATCH 1/3] expose eth_is_active() function to test network device state

[Joe Hershberger]

Hi Simon,

On Mon, Aug 24, 2015 at 11:59 AM, Simon Glass <sjg at chromium.org> wrote:
> +Hans
>
> Hi Bernhard,
>
> On 24 August 2015 at 04:20, Bernhard Nortmann <bernhard.nortmann at web.de> wrote:
>> Hi Simon!
>>
>> Am 23.08.2015 23:21, schrieb Simon Glass:
>>>
>>> A few points:
>>>
>>> - You should tag your patch with the subsystem it targets - in your
>>> case I think you should prefix the subject with 'net: '
>>
>> Okay. I'll keep that in mind for future reiterations of this patch set.
>> Btw: Thanks for looking into my stuff.
>>
>>> - Do you have a patch to enable netconsole on an existing board? If
>>> the code you add is never built then it could break at any moment
>>
>> netconsole seems to receive little love actually :D (It's been broken /
>> would
>> cause compilation errors with CONFIG_DM_ETH for quite some time now,
>> since commit b6006baf9c2553543e3384983d23d95efbf24fa6 in April.)
>> So I'm not sure I get your question. As mentioned in the cover letter I've
>> been testing this code with and without CONFIG_DM_ETH for my Banana Pi,
>> i.e. sunxi GMAC (by simply adding #define CONFIG_NETCONSOLE).
>
> In that case how about adding that config to that board? Does it cause
> problems for other people?

I'll pile on and agree that it would be great to have at least one
board with this enabled, and even better to have one that supports
DM_ETH and one that does not.

-Joe