[U-Boot] [RFC v3 PATCH 1/4] dm: do not return pointer if NULL is given to devp of device_bind()

Masahiro Yamada yamada.masahiro at socionext.com
Tue Aug 25 08:41:43 CEST 2015


Hi Simon,

2015-08-12 23:15 GMT+09:00 Simon Glass <sjg at chromium.org>:
> Hi Masahiro,
>
> On 10 August 2015 at 10:05, Masahiro Yamada
> <yamada.masahiro at socionext.com> wrote:
>> This is useful when we want to bind a device, but do not need the
>> device pointer.
>
> Could adjust the subject to something shorter, like "dm: core: Allow
> device_bind() to not return the device"

Done. Thanks.


eturn -EINVAL;
>>
>> @@ -133,7 +134,8 @@ int device_bind(struct udevice *parent, const struct driver *drv,
>>
>>         if (parent)
>>                 dm_dbg("Bound device %s to %s\n", dev->name, parent->name);
>> -       *devp = dev;
>> +       if (devp)
>> +               *devp = dev;
>>
>>         dev->flags |= DM_FLAG_BOUND;
>>
>> --
>> 1.9.1
>>
>
> Please can you update the function comments for device_bind()?


Done for device_bind() and others.



-- 
Best Regards
Masahiro Yamada


More information about the U-Boot mailing list