[U-Boot] [RFC v3 PATCH 3/4] pinctrl: add simple pinctrl implementation

[Masahiro Yamada]

Hi Simon,


2015-08-12 23:16 GMT+09:00 Simon Glass <sjg at chromium.org>:

>> diff --git a/include/dm/pinctrl.h b/include/dm/pinctrl.h
>> index 42008da..b2ba0b4 100644
>> --- a/include/dm/pinctrl.h
>> +++ b/include/dm/pinctrl.h
>> @@ -85,6 +85,8 @@ struct pinctrl_ops {
>>         int (*pinconf_group_set)(struct udevice *dev, unsigned group_selector,
>>                                  unsigned param, unsigned argument);
>>         int (*set_state)(struct udevice *dev, struct udevice *config);
>> +       /* for pinctrl-simple */
>> +       int (*set_state_simple)(struct udevice *dev, struct udevice *periph);
>
> So should the other members be #idef'd out? Also, comments on this function?
>

After my careful consideration, I did not do this.

If we do this,the corresponding members in all drivers must be also
#ifdef'd out,
including full-pinctrl drivers that do not care about memory footprint.

I do not like adding #ifdefs around to fix build errors found with
"make allyesconfig", "make randconfig".

I think it is a general strategy to not #ifdef out struct members.



-- 
Best Regards
Masahiro Yamada