[U-Boot] [PATCH v3 5/7] video: cfb_console: Allow VGA device to work without i8042 keyboard

Anatolij Gustschin agust at denx.de
Tue Aug 25 09:54:28 CEST 2015


Hi Simon,

On Mon, 24 Aug 2015 22:13:41 -0600
Simon Glass <sjg at chromium.org> wrote:

> On 24 August 2015 at 02:00, Bin Meng <bmeng.cn at gmail.com> wrote:
> > So far if CONFIG_VGA_AS_SINGLE_DEVICE is not defined, the VGA device
> > will try to initialize a keyboard device (for x86, it is i8042). But
> > if i8042 controller initialization fails (eg: there is no keyboard
> > connected to the PS/2 port), drv_video_init() just simply returns.
> > This kills the opportunity of using a usb keyboard later with the vga
> > console, as the vga initialization part is actually ok, only keyboard
> > part fails. Change the code logic to allow this.
> >
> > Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> What are your thoughts on this patch, please?

it is okay for me, please merge it with other patches in this series.

Thanks,

Anatolij


More information about the U-Boot mailing list