[U-Boot] [RFC PATCH 1/3] expose eth_is_active() function to test network device state

[Joe Hershberger]

Hi Bernhard,

On Tue, Aug 25, 2015 at 1:01 PM, Bernhard Nortmann
<bernhard.nortmann at web.de> wrote:
> Am 25.08.2015 um 17:55 schrieb Joe Hershberger:
>> Hi Bernhard,
>>
>> [...]
>> It's good to have a build target and also a test or so. We should
>> maybe enable it in sandbox.
>
> I'm not familiar at all with the U-Boot "sandbox" architecture, so I'd
> prefer
> to leave that to someone else.
>
>> I'm pretty sure CamelCase is used in NetConsole.
>
> Thanks, I'll fix that.
>
>> I guess that will work (not running moveconfig.pl) with
>> CONFIG_NETCONSOLE since so far most boards that don't define
>> CONFIG_DM_ETH don't define CONFIG_NET or CONFIG_NETDEVICES so that
>> CONFIG_NETCONSOLE option wouldn't be available. We'll have to change
>> that for next release.
>>
>> -Joe
>
> Yes, that Kconfig vs. "legacy" options battle is a bit of a problem. If it
> keeps things simpler for now, I could add "NETCONSOLE" to the respective
> CONFIG_SYS_EXTRA_OPTIONS as an alternative approach, and leave that Kconfig
> migration for the future. Which do you prefer?

I think it will be better to take the approach you already are (add to
Kconfig). Just make sure you use savedefconfig when you add the option
to the bananapi defconfig.

Thanks,
-Joe