[U-Boot] [PATCH 8/9] net: pch_gbe: Add Kconfig option

[Bin Meng]

Hi Joe,

On Wed, Aug 26, 2015 at 3:10 AM, Joe Hershberger
<joe.hershberger at gmail.com> wrote:
> Hi Bin,
>
> (with list this time)
>
> On Tue, Aug 25, 2015 at 2:22 AM, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Add Kconfig option in preparation for moving board to use Kconfig.
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>> ---
>>
>>  drivers/net/Kconfig | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>> index 7367d9e..ccaf675 100644
>> --- a/drivers/net/Kconfig
>> +++ b/drivers/net/Kconfig
>> @@ -79,4 +79,13 @@ config ETH_DESIGNWARE
>>           100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
>>           provide the PHY (physical media interface).
>>
>> +config PCH_GBE
>> +       bool "Intel Platform Controller Hub EG20T GMAC driver"
>> +       depends on DM_PCI
>> +       default n
>> +       help
>> +         This MAC is present in Intel Platform Controller Hub EG20T. It
>> +         supports 10/100/1000 Mbps operation. You must enable CONFIG_PHYLIB
>> +         to provide the PHY (physical media interface).
>
> You should not have statements like this in the help. You should
> either "select" or "depends on" PHYLIB in this config (I would use
> select). Also this depends DM_ETH as well.
>

Yep, looks that I need prepare a new patch to convert PHYLIB to a
Kconfig option first. As for dependency on DM_ETH, I think this is
already indicated by NETDEVICES which is default y if DM_ETH.

Regards,
Bin