[U-Boot] [PATCH 6/9] x86: crownbay: Convert to use CONFIG_DM_ETH for E1000

[Joe Hershberger]

On Tue, Aug 25, 2015 at 9:28 PM, Simon Glass <sjg at chromium.org> wrote:
> Hi,
>
> On 25 August 2015 at 19:20, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Hi Joe,
>>
>> On Wed, Aug 26, 2015 at 2:59 AM, Joe Hershberger
>> <joe.hershberger at gmail.com> wrote:
>>> Hi Bin,
>>>
>>> On Tue, Aug 25, 2015 at 2:22 AM, Bin Meng <bmeng.cn at gmail.com> wrote:
>>>> Since E1000 driver has been converted to driver model, enable it
>>>> on Intel Crown Bay. But the Intel Topcliff GbE driver has not been
>>>> converted to driver model yet, disable it for now.
>>>
>>> If you reorder your series a bit you can squash this into the last
>>> patch, right? That would be more clear. You can simply move patch 7 &
>>> 8 to before this one and you can squash 9 into 6.
>>
>> I cannot squash this into the last patch because when patch 7 comes,
>> it breaks Intel Crown Bay board build as non-dm version is gone.
>> That's why you see in this patch when I turned on CONFIG_DM_ETH, I
>> also disabled CONFIG_PCH_GBE (non-dm driver). Then after patch 7
>> converts the pch_gbe driver to dm, I added that driver back in patch
>> 9. This way it passes buildman testing without breaking bisectability.
>>
>> But if you think we can break such kind of bisectability, I can
>> reorder these patches.
>
> No, we should keep bisectability. It's just such a pain chasing down
> regressions otherwise.

Yep