[U-Boot] [PATCH v2 09/10] net: pch_gbe: Add Kconfig option

[Joe Hershberger]

Hi Bin,

On Wed, Aug 26, 2015 at 10:34 AM, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Joe,
>
> On Wed, Aug 26, 2015 at 11:23 PM, Joe Hershberger
> <joe.hershberger at gmail.com> wrote:
>> Hi Bin,
>>
>> On Wed, Aug 26, 2015 at 8:17 AM, Bin Meng <bmeng.cn at gmail.com> wrote:
>>> Add Kconfig option in preparation for moving board to use Kconfig.
>>>
>>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>>>
>>> ---
>>>
>>> Changes in v2:
>>> - Add PHYLIB Kconfig option and let PCH_GBE select PHYLIB
>>>
>>>  drivers/net/Kconfig | 15 +++++++++++++++
>>>  1 file changed, 15 insertions(+)
>>>
>>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>>> index 7367d9e..5e1687b 100644
>>> --- a/drivers/net/Kconfig
>>> +++ b/drivers/net/Kconfig
>>> @@ -8,6 +8,12 @@ config DM_ETH
>>>           This is currently implemented in net/eth.c
>>>           Look in include/net.h for details.
>>>
>>> +config PHYLIB
>>> +       bool
>>
>> I don't think we want this as an unchoose-able option. You should
>> include some bool text.
>
> I hide it from menuconfig, as I thought this was actually a driver
> requirement, not something user can choose. Even if someone selects
> this option in the menuconfig, without an ethernet driver to make use
> of it, it is useless.

Based on its selection, the capability of CMD_MII is altered. It
certainly is tied to the driver though. I guess I could go either way.

>>
>>> +       default n
>>
>> This is not needed, remove it.
>
> OK
>
>>
>>> +       help
>>> +         Enable Ethernet PHY (physical media interface) support.
>>> +
>>>  menuconfig NETDEVICES
>>>         bool "Network device support"
>>>         depends on NET
>>> @@ -79,4 +85,13 @@ config ETH_DESIGNWARE
>>>           100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
>>>           provide the PHY (physical media interface).
>>>
>>> +config PCH_GBE
>>> +       bool "Intel Platform Controller Hub EG20T GMAC driver"
>>> +       depends on DM_ETH && DM_PCI
>>> +       select PHYLIB
>>> +       default n
>>
>> This is not needed, remove it.
>
> OK
>
>>
>>> +       help
>>> +         This MAC is present in Intel Platform Controller Hub EG20T. It
>>> +         supports 10/100/1000 Mbps operation.
>>> +
>>>  endif # NETDEVICES
>>> --
>
> Regards,
> Bin