[U-Boot] [PATCH 1/2] tools/atmelimage.c: Fix warning when debug is enabled

Tom Rini trini at konsulko.com
Thu Aug 27 13:26:33 CEST 2015


On Thu, Aug 27, 2015 at 12:37:52PM +0200, Andreas Bießmann wrote:
> Hi Tom,
> 
> On 08/26/2015 09:21 PM, Tom Rini wrote:
> > Otherwise we get:
> > tools/atmelimage.c:134:3: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘size_t’ [-Wformat=]
> > debug("atmelimage: interrupt vector #%d is 0x%08X\n", pos+1,
> > ^
> > 
> > Signed-off-by: Tom Rini <trini at konsulko.com>
> > ---
> >  tools/atmelimage.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/atmelimage.c b/tools/atmelimage.c
> > index 5b72ac5..0979eef 100644
> > --- a/tools/atmelimage.c
> > +++ b/tools/atmelimage.c
> > @@ -131,7 +131,7 @@ static int atmel_verify_header(unsigned char *ptr, int image_size,
> >  
> >  	/* check the seven interrupt vectors of binary */
> >  	for (pos = 0; pos < 7; pos++) {
> > -		debug("atmelimage: interrupt vector #%d is 0x%08X\n", pos+1,
> > +		debug("atmelimage: interrupt vector #%ld is 0x%08X\n", pos+1,
> 
> I'd rather use the '%zu' modifier here. On 32 Bit systems the size_t
> might be a simple int and not a long int which also leads to warnings.

Oh that's right, %zu is what you should do for size_t.  I thought I was
doing something wrong but couldn't recall.  Thanks, I'll v2 later today.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150827/297db970/attachment.sig>


More information about the U-Boot mailing list