[U-Boot] [PATCH 3/4] mtd: nand: Make CONFIG_SYS_NAND_U_BOOT_OFFS configurable through Kconfig

[Hans de Goede]

Hi,

On 26-08-15 21:08, Scott Wood wrote:
> On Wed, 2015-08-26 at 19:38 +0100, Ian Campbell wrote:
>> On Sat, 2015-08-22 at 20:13 +0200, Hans de Goede wrote:
>>> Make CONFIG_SYS_NAND_U_BOOT_OFFS configurable through Kconfig, just
>>> like
>>> SYS_NAND_BUSWIDTH_16BIT this is only enabled on some SoCs using
>>> depends,
>>> to avoid double defining it for SoCs which have not yet moved to
>>> Kconfig
>>> for this.
>>>
>>> Having this in Kconfig is useful because this is something which may
>>> differ from one board to the other even when using the same SoC.
>>>
>>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>>
>> For the sunxi side:
>> Acked-by: Ian Campbell <ijc at hellion.org.uk>
>>
>> (But needs MTD custodian's more, I guess that is Scott?)
>
> Acked-by: Scott Wood <scottwood at freescale.com>
>
> ...but note that this is one of the symbols that can never be kconfigized for
> the boards that use TPL, so long as SPLs can't have their own config.

Hmm, maybe we beed to have 2 values for it then:
CONFIG_SYS_NAND_SPL_U_BOOT_OFFS
CONFIG_SYS_NAND_TPL_U_BOOT_OFFS

And select which one to use depending we are building the SPL or the TPL,
then both could go to Kconfig

> I'm also not looking forward to such symbols growing a huge list of boards in
> the depends field.  I'm not sure what the answer is here.

See above, if we do something like that, then at one point in time we
can choose to put in some effort to convert the remaining boards,
and just drop the depends.

Regards,

Hans