[U-Boot] [PATCH v2 01/28] tpm: Remove old pre-driver-model I2C code

Simon Glass sjg at chromium.org
Mon Aug 31 00:42:50 CEST 2015


Hi Heiko,

On 23 August 2015 at 23:15, Heiko Schocher <hs at denx.de> wrote:
> Hello Simon,
>
> Am 24.08.2015 um 06:52 schrieb Simon Glass:
>>
>> Hi Heiko,
>>
>> On 23 August 2015 at 22:50, Heiko Schocher <hs at denx.de> wrote:
>>>
>>> Hello Simon,
>>>
>>> Am 23.08.2015 um 02:31 schrieb Simon Glass:
>>>>
>>>>
>>>> This is not used anymore by any board so drop it.
>>>>
>>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>>> Acked-by: Christophe Ricard <christophe-h.ricard at st.com>
>>>> ---
>>>>
>>>> Changes in v2: None
>>>>
>>>>    drivers/tpm/tpm.c         | 108
>>>> ++--------------------------------------------
>>>>    drivers/tpm/tpm_private.h |   4 +-
>>>>    drivers/tpm/tpm_tis_i2c.c |  74 +------------------------------
>>>>    3 files changed, 7 insertions(+), 179 deletions(-)
>>>
>>>
>>>
>>> Thanks for your work! Nitpick ...
>>>
>>> $ grep -lr CONFIG_TPM_TIS_I2C include/configs/
>>> include/configs/exynos5-common.h
>>>
>>> So I miss the removal of this define there and maybe
>>> remove it in drivers/tpm/Makefile ...
>>>
>>> Beside of this ...
>>>
>>> Reviewed-by: Heiko Schocher <hs at denx.de>
>>
>>
>> The driver still exists though - I am just removing part of the code.
>> Or do I misunderstand what you are getting at?
>
>
> Huh... seems to early ... I thought you remove the complete driver,
> Sorry ... all is fine.
>
> I looked through your patchserie, seems fine to me, so, you can add
> my Reviewed-by: Heiko Schocher <hs at denx.de> for the hole series.

OK done, thanks for taking a look. Christophe has some additions to
come but this is a good base. I'm going to apply this series to
u-boot-dm and get it in now. The I2C driver needs to be renamed to
infineon, will deal with that later.

Applied to u-boot-dm.


More information about the U-Boot mailing list