[U-Boot] [PATCH v4 27/33] rockchip: Add an MMC driver

[Simon Glass]

Hi Andre,

On 25 August 2015 at 12:26, Andre Przywara <andre.przywara at arm.com> wrote:
> Hi Simon,
>
> On 24/08/15 16:12, Simon Glass wrote:
>> Add an MMC driver which supports RK3288, but may also support other SoCs.
>> It uses the Designware MMC device.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>> Changes in v4: None
>> Changes in v3: None
>> Changes in v2: None
>>
>>  drivers/mmc/Kconfig        |  9 +++++
>>  drivers/mmc/Makefile       |  1 +
>>  drivers/mmc/rockchip_mmc.c | 98 ++++++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 108 insertions(+)
>>  create mode 100644 drivers/mmc/rockchip_mmc.c

[snip]

>> +U_BOOT_DRIVER(rockchip_mmc_drv) = {
>> +     .name           = "rockchip_mmc",
>> +     .id             = UCLASS_MMC,
>> +     .of_match       = rockchip_mmc_ids,
>> +     .ofdata_to_platdata = rockchip_mmc_ofdata_to_platdata,
>> +     .probe          = rockchip_mmc_probe,
>> +     .priv_auto_alloc_size = sizeof(struct dwmci_host),
>
> Shouldn't that be "sizeof(struct rockchip_mmc_priv)" here instead? (I
> mentioned that already before, just not sure whether that mail got lost
> or I was just talking nonsense back then).

Yes it should, thank you for catching that!

Regards,
Simon