[U-Boot] [RFC v3 PATCH 2/4] pinctrl: add pin control uclass support

Simon Glass sjg at chromium.org
Mon Aug 31 00:45:28 CEST 2015


Hi Masahiro,

On 26 August 2015 at 22:52, Masahiro Yamada
<yamada.masahiro at socionext.com> wrote:
> Hi Simon
>
> I missed to answer the first of the two.
>
>
> 2015-08-26 12:06 GMT+09:00 Simon Glass <sjg at chromium.org>:
>
>> Two more things:
>> - What to do about tests?
>> - Please can you check my patches here and provide your comments:
>>
>> http://patchwork.ozlabs.org/patch/510082/
>> http://patchwork.ozlabs.org/patch/510079/
>
>
>
> My first idea was:
>
>  - Decide register map for sandbox-pinctrl device and specification
> for pinmux and pinconf
>  - Add reg property to sandbox-pinctrl node.
>  - ioremap the register region in sandbox_pinctrl_probe()  (and
> iounmap in _remove())
>  - Set registers in sandbox_pinmux_set() and sandbox_pinconf_set()
>  - Probe some peropherals; _pinmux_set() and pinconf_set() should be
> called for those peripherals
>  - DM test functions read back the pinctrl registers and check if the
> expected values are set
>
>
>
> Now I do not have enough time for this.
>
> Are you willing to work on a testing routine?
> (You do not have to stick to my idea.   Please feel free to use your own idea.)

Yes we have to have this figured out. The pinctrl stuff has already
come in late and we really need to get it in soon. If you don't get to
this I'll give it a try when things settle down.

Regards,
Simon


More information about the U-Boot mailing list