[U-Boot] [RFC PATCH 11/11] board: Add Qualcomm Dragonboard 410C support

[Mateusz Kulikowski]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Simon,
 
On 16.12.2015 23:29, Simon Glass wrote:
> Hi Mateusz,
> 
> On 10 December 2015 at 14:41, Mateusz Kulikowski
> <mateusz.kulikowski at gmail.com> wrote:
[...]
> 
>> +
>> +int board_prepare_usb(enum usb_init_type type)
>> +{
>> +       int ret = 0, node;
>> +
>> +       /* Try to request gpios needed to start usb host on dragonboard */
>> +       if (!dm_gpio_is_valid(&hub_reset)) {
>> +               node = fdt_subnode_offset(gd->fdt_blob, 0,
>> +                                         "usb_hub_reset_n_pm");
> 
> Is this really the standard binding? I would expect a USB node with a
> reset-gpios property.
> 

That's a good idea.

[...]
>> +
>> +/* Check for vol- button - if pressed - stop autoboot */
>> +int misc_init_r(void)
>> +{
>> +       int node;
>> +       struct gpio_desc resin;
>> +
>> +       node = fdt_subnode_offset(gd->fdt_blob, 0, "key_vol_down");
> 
> Should this be a GPIO key?

Yes, but I couldn't find something like that in U-Boot.. did I missed it?

[...]
>> +
>> +OUTPUT_FORMAT("elf64-littleaarch64", "elf64-littleaarch64", "elf64-littleaarch64")
>> +OUTPUT_ARCH(aarch64)
>> +ENTRY(_fastboot_header)
> 
> I wonder if you could use the standard .lds file and amend it to
> support fastboot?

Perhaps it's a good idea to make it generic option (at least for ARMv8 devices).

I'm not sure is it "generic" fastboot header or only works for Little Kernel 
on Qualcomm devices though.

@Albert what do you think?

> 
>> +SECTIONS
>> +{
>> +       . = 0x00000000;
>> +
>> +       . = ALIGN(8);
>> +       .text :
>> +       {
>> +               *(.__image_copy_start)
>> +               board/qualcomm/dragonboard410c/head.o (.text*)
>> +               CPUDIR/start.o (.text*)
>> +               *(.text*)
>> +       }
>> +

Regards,
Mateusz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWdUxgAAoJELvtohmVtQzBSV0IAIeIJSDENgvWvR5Q7hkmGYWQ
y+M0QWFaZpAD+iyOsHBelRWpaOTlrjrnG7n9aAsUf6VUJ8d70p8dPDgycxoRyrtw
QdWGTfamlO3V9/cw0iLKlWpz3xXZXIVkMrLyhggZkA4anGMSopvNkuOs42LQSgnp
dOUJAEbLgwZBlALlZH3uAdpSuAYywbfDhyyXGXH4sCHhx2wNnLJjr4sXLoamz8Jd
2o9ITZfr5TAl3fWTxSRN0XHxUeFRYLUywpSyqmI9A3ajtsRSh8uPzde2v3PP6qjI
Qw94RrF2QWKSLu/OMehajcWzG6VYYKaGc0nMMmLV6aHL1VNI9FjRpUcSraHhU0A=
=AVPb
-----END PGP SIGNATURE-----