[U-Boot] [RFC PATCH 11/11] board: Add Qualcomm Dragonboard 410C support

[Simon Glass]

Hi Mateusz,

On 19 December 2015 at 05:24, Mateusz Kulikowski
<mateusz.kulikowski at gmail.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Hi Simon,
>
> On 16.12.2015 23:29, Simon Glass wrote:
>> Hi Mateusz,
>>
>> On 10 December 2015 at 14:41, Mateusz Kulikowski
>> <mateusz.kulikowski at gmail.com> wrote:
> [...]
>>
>>> +
>>> +int board_prepare_usb(enum usb_init_type type)
>>> +{
>>> +       int ret = 0, node;
>>> +
>>> +       /* Try to request gpios needed to start usb host on dragonboard */
>>> +       if (!dm_gpio_is_valid(&hub_reset)) {
>>> +               node = fdt_subnode_offset(gd->fdt_blob, 0,
>>> +                                         "usb_hub_reset_n_pm");
>>
>> Is this really the standard binding? I would expect a USB node with a
>> reset-gpios property.
>>
>
> That's a good idea.
>
> [...]
>>> +
>>> +/* Check for vol- button - if pressed - stop autoboot */
>>> +int misc_init_r(void)
>>> +{
>>> +       int node;
>>> +       struct gpio_desc resin;
>>> +
>>> +       node = fdt_subnode_offset(gd->fdt_blob, 0, "key_vol_down");
>>
>> Should this be a GPIO key?
>
> Yes, but I couldn't find something like that in U-Boot.. did I missed it?
>
> [...]
>>> +
>>> +OUTPUT_FORMAT("elf64-littleaarch64", "elf64-littleaarch64", "elf64-littleaarch64")
>>> +OUTPUT_ARCH(aarch64)
>>> +ENTRY(_fastboot_header)
>>
>> I wonder if you could use the standard .lds file and amend it to
>> support fastboot?
>
> Perhaps it's a good idea to make it generic option (at least for ARMv8 devices).
>
> I'm not sure is it "generic" fastboot header or only works for Little Kernel
> on Qualcomm devices though.
>
> @Albert what do you think?

I see later that you plan to remove this one day, so perhaps it is
fine to keep it as it is.

>
>>
>>> +SECTIONS
>>> +{
>>> +       . = 0x00000000;
>>> +
>>> +       . = ALIGN(8);
>>> +       .text :
>>> +       {
>>> +               *(.__image_copy_start)
>>> +               board/qualcomm/dragonboard410c/head.o (.text*)
>>> +               CPUDIR/start.o (.text*)
>>> +               *(.text*)
>>> +       }
>>> +


Regards,
Simon