[U-Boot] [RFC PATCH v2 2/6] x86: quark: Add routines to access message bus registers

Bin Meng bmeng.cn at gmail.com
Mon Feb 2 03:02:00 CET 2015


Hi Simon,

On Mon, Feb 2, 2015 at 12:30 AM, Simon Glass <sjg at chromium.org> wrote:
> On 29 January 2015 at 02:18, Bin Meng <bmeng.cn at gmail.com> wrote:
>> In the Quark SoC, some chipset commands are accomplished by utilizing
>> the internal message network within the host bridge (D0:F0). Accesses
>> to this network are accomplished by populating the message control
>> register (MCR), Message Control Register eXtension (MCRX) and the
>> message data register (MDR).
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>>
>> ---
>>
>> Changes in v2:
>> - Add msg_port_setup() and remove MCR_FILL
>> - Add MSG_BYTE_ENABLE define
>> - Wrap function declaraion with __ASSEMBLY__
>>
>>  arch/x86/cpu/quark/msg_port.c              |  77 +++++++++++++++++++++
>>  arch/x86/include/asm/arch-quark/msg_port.h | 106 +++++++++++++++++++++++++++++
>>  2 files changed, 183 insertions(+)
>>  create mode 100644 arch/x86/cpu/quark/msg_port.c
>>  create mode 100644 arch/x86/include/asm/arch-quark/msg_port.h
>>
>
> Acked-by: Simon Glass <sjg at chromium.org>
>
> I'd still prefer lower case hex.
>

OK, will fix in v3.

Regards,
Bin


More information about the U-Boot mailing list