[U-Boot] [PATCH v2 1/5] microblaze: Move architecture to use generic board init

[Simon Glass]

Hi Michal,

On 3 February 2015 at 02:26, Michal Simek <michal.simek at xilinx.com> wrote:
> Hi Simon,
>
> On 02/03/2015 12:58 AM, Simon Glass wrote:
>> Hi Michal,
>>
>> On 2 February 2015 at 08:46, Michal Simek <michal.simek at xilinx.com> wrote:
>>> Compile code with -fPIC to get GOT. Do not build SPL
>>> with fPIC because it increasing SPL size for nothing.
>>>
>>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>>> ---
>>>
>>> Changes in v2:
>>> - Use dram_init instead of init_func_ram()
>>>   Suggested by Simon
>>>
>>> This code requires
>>> "common/board_r: manual relocation for cmd table"
>>> http://lists.denx.de/pipermail/u-boot/2015-January/201965.html
>>>
>>> Not fully happy about it because compare to previous solution adds
>>> almost +60k on size for doing the same thing as before.
>>>
>>> 15: microblaze: Move architecture to use generic board init
>>> microblaze: (for 1/1 boards)  all +52268.0  bss -4.0  data +11724.0
>>> rodata -2676.0  spl/u-boot-spl:all +36.0  spl/u-boot-spl:data +36.0
>>> text +43224.0
>>>             microblaze-generic:  all +52268  bss -4  data +11724  rodata
>>> -2676  spl/u-boot-spl:all +36  spl/u-boot-spl:data +36  text +43224
>>>
>>> Depends on:
>>> http://lists.denx.de/pipermail/u-boot/2015-January/203277.html
>>
>> Yes that seems crazy.
>>
>> You can use -B to see what code is added. Can you figure it out?
>
> I was checking this with our toolchain guy and expectation with fPIC/fPIE
> is 20% bigger code and I am below that.
>
> I was checking -B output too and it is adding bytes to every function
> that's why the sum is that big.

OK, that's unfortunate but sounds like it is a feature of the
architecture, so nothing wrong with U-Boot per se.

Regards,
Simon