[U-Boot] [PATCH 3/4] malloc_simple: Return NULL on malloc failure rather then calling panic()

Simon Glass sjg at chromium.org
Thu Feb 5 04:04:56 CET 2015


On 4 February 2015 at 05:05, Hans de Goede <hdegoede at redhat.com> wrote:
> All callers of malloc should already do error checking, and may even be able
> to continue without the alloc succeeding.
>
> Moreover, common/malloc_simple.c is the only user of .rodata.str1.1 in
> common/built-in.o when building the SPL, triggering this gcc bug:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54303
>
> Causing .rodata to grow with e.g. 0xc21 bytes, nullifying all benefits of
> using malloc_simple in the first place.
>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> ---
>  common/malloc_simple.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Great find, thanks!

Acked-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list