[U-Boot] [PATCH 5/5] RFC: sunxi: WIP FEL support

[Hans de Goede]

Hi,

On 05-02-15 03:52, Simon Glass wrote:
> Hi Hans,
>
> On 4 February 2015 at 01:47, Hans de Goede <hdegoede at redhat.com> wrote:
>> Hi,
>>
>> On 04-02-15 05:18, Simon Glass wrote:
>>>
>>> (What does FEL stand for?)
>>>
>>> This is an attempt to make sunxi's FEL code fit with the normal U-Boot
>>> boot sequence instead of creating its own.
>>>
>>> Most of the FEL special-case code is removed, although I may have gone too
>>> far with my changes to generate a u-boot-sunxi-with-spl.bin file even when
>>> FEL is enabled. This may not be possible since the MMC stack makes SPL
>>> too large for FEL anyway, although it may be possible for other boot
>>> mediums.
>>>
>>> This series is available at u-boot-dm, branch sunxi-working.
>>
>>
>> Thanks for working on this, I like the direction where this is heading,
>> if Albert is ok with the start.S changes this would be an excellent way
>> to fix FEL mode for v2015.04.
>
> OK great!
>
>>
>> WRT you going to far when also building a u-boot-sunxi-with-spl.bin when
>> FEL is enabled, your right, AFAIK that binary will not work when written
>> to sdcard because FEL mode has a CONFIG_SPL_TEXT_BASE of 0x2000 where
>> as non FEL has CONFIG_SPL_TEXT_BASE set to 0x0020.
>>
>> But we've discussed in the past to use 0x2000 everywhere, this would mean
>> moving the stack pointer to 0x2000 instead of 0x8000, and then making
>> the normal SPL fit between 0x2000 - 0x8000.
>>
>> All you need to change then AFAIK is tools/mksunxiboot.c so that the jump
>> instruction which is the first 32 bit word of the header it generates jumps
>> to 0x2000 rather then 0x0020, and then we may be able to have a unified
>> build which does both FEL and regular SPL for sdcard boot.
>
> Interesting, I wondered about that.
>
> I see your other series too so this could all fit quite nicely. I'll
> focus on getting this series through with Albert's help.

Great, thanks for working on this. About the having one unified SPL,
I believe that that is probably best left as something to do for
v2015.07, and that we should just try to get your work to fix FEL mode
to work in for v2015.04, do you agree ?

I'm asking because I'm wondering what the plan is wrt merging my
SPL size reduction series, we could in theory add that to v2015.04,
but it can also wait, and from a merge window pov it should wait.

If we want to add it to v2015.04 anyways I can take it upstream in its
entirety through u-boot-sunxi, or you can first merge the 2
malloc_simple patches through u-boot-dm.

Regards,

Hans