[U-Boot] [PATCH 2/2] ARM: UniPhier: leave the last element of boot_device_table empty

Masahiro Yamada yamada.m at jp.panasonic.com
Thu Feb 5 12:56:24 CET 2015


Checking if the pointer is NULL would be easier to know the tail
of the boot_device_table[] array.
For clarification, add the /* sentinel */ comment.

Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
---

 arch/arm/cpu/armv7/uniphier/cmd_pinmon.c         | 2 +-
 arch/arm/cpu/armv7/uniphier/ph1-pro4/boot-mode.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/cpu/armv7/uniphier/cmd_pinmon.c b/arch/arm/cpu/armv7/uniphier/cmd_pinmon.c
index d8a6361..3c1b325 100644
--- a/arch/arm/cpu/armv7/uniphier/cmd_pinmon.c
+++ b/arch/arm/cpu/armv7/uniphier/cmd_pinmon.c
@@ -19,7 +19,7 @@ static int do_pinmon(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 
 	puts("Boot Mode Pin:\n");
 
-	for (i = 0; strlen(boot_device_table[i].info); i++)
+	for (i = 0; boot_device_table[i].info; i++)
 		printf(" %c %02x %s\n", i == mode_sel ? '*' : ' ', i,
 		       boot_device_table[i].info);
 
diff --git a/arch/arm/cpu/armv7/uniphier/ph1-pro4/boot-mode.c b/arch/arm/cpu/armv7/uniphier/ph1-pro4/boot-mode.c
index 90d4186..c31b74b 100644
--- a/arch/arm/cpu/armv7/uniphier/ph1-pro4/boot-mode.c
+++ b/arch/arm/cpu/armv7/uniphier/ph1-pro4/boot-mode.c
@@ -45,7 +45,7 @@ struct boot_device_info boot_device_table[] = {
 	{BOOT_DEVICE_NONE, "Reserved"},
 	{BOOT_DEVICE_NONE, "Reserved"},
 	{BOOT_DEVICE_NONE, "Reserved"},
-	{BOOT_DEVICE_NONE, ""}
+	{ /* sentinel */ }
 };
 
 int get_boot_mode_sel(void)
-- 
1.9.1



More information about the U-Boot mailing list