[U-Boot] [PATCH 1/3] ARmv7: Add a soc_init hook to start.S

[Simon Glass]

Hi Albert,

On 5 February 2015 at 11:02, Albert ARIBAUD <albert.u.boot at aribaud.net> wrote:
> Hello Simon,
>
> On Thu, 5 Feb 2015 08:34:53 -0700, Simon Glass <sjg at chromium.org> wrote:
>> Hi Albert,
>
>> >> reset - no stack, no RAM ( (except SPL can presumably access data section)
>> >
>> > More precisely: from a hardware viewpoint there would be no DDR, but
>> > there could be SRAM, and from a program viewpoint, no stack and no
>> > writable data: text, rodata and initialized data sections could be read
>> > from, but should never be written to.
>>
>> I can see in some rare cases we would want to store data here (as you
>> say in the next paragraph) and in that case, initialised data is a
>> good option - we cannot use BSS and it is ugly to write to memory
>> directly. My sunxi patches store lr and sp, for example.
>
> Not sure I'm getting your "initialized data is a good option", as
> initialized data, just like BSS, cannot be written at reset stage.

I mean in SPL - in this case we are running from SRAM. But in the
general case I'm not sure where we could store anything. In any case
this can be board-specific.

>
>> > "layout" does not entirely cover what board_init_f() does, though, and
>> > I don't like "init" when what it does is actually resetting the board
>> > to a known state -- yes, I know we often use "reset" for "restart". How
>> > about this?
>> >
>> >         "start"
>> >         "init"
>> >         "forerun"
>> >         "run"
>> >
>> > You've got the "f" that you wanted :) and the "run" in the third and
>> > last stage are nice reminders that we do have a run-time C environment
>> > there, except the third stage is not quite a running environment yet.
>>
>> All of the above sounds good to me. Yes forerun has an f. I think it
>> is better than the other things I can think of (find, furnish,
>> formulate, fabricate, former)
>
> "Anything else we does beginnin' with F, boys?" -- Otis McCoy, head of
> the "feudin', fightin', feedin', funnin', flatin' McCoys" gang, /in/
> the Judge Dredd (the comics) story "Alabama Blimps".

You've got them all.

Regards,
Simon