[U-Boot] [RFC PATCH v2 5/9] x86: quark: Add System Memory Controller support

[Simon Glass]

On 5 February 2015 at 08:42, Bin Meng <bmeng.cn at gmail.com> wrote:
> The codes are actually doing the memory initialization stuff.
>
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>
> ---
> The most ugly codes I've ever seen ...
> There are 252 warnings and 127 checks in this patch, which are:
>
> check: arch/x86/cpu/quark/smc.c,1609: Alignment should match open parenthesis
> warning: arch/x86/cpu/quark/smc.c,1610: line over 80 characters
> warning: arch/x86/cpu/quark/smc.c,1633: Too many leading tabs - consider code refactoring
> ...
>
> Fixing 'Too many leading tabs ...' will be very dangerous, as I don't have
> all the details on how Intel's MRC codes are actually written to play with
> the hardware. Trying to refactor them may lead to a non-working MRC codes.
> For the 'line over 80 characters' issue, we have to leave them as is now
> due to the 'Too many leading tabs ...'. If I am trying to fix the 'Alignment
> should match open parenthesis' issue, I may end up adding more 'line over 80
> characters' issues, so we have to bear with it. Sigh.
>
> Changes in v2:
> - Write out the values instead of BIT in smc.h
> - Removing the ending / in the file header comment block
>
>  arch/x86/cpu/quark/smc.c | 2764 ++++++++++++++++++++++++++++++++++++++++++++++
>  arch/x86/cpu/quark/smc.h |  446 ++++++++
>  2 files changed, 3210 insertions(+)
>  create mode 100644 arch/x86/cpu/quark/smc.c
>  create mode 100644 arch/x86/cpu/quark/smc.h

As with the other patch we should be able to tidy this up a little
more before the release (splitting code, reducing use of BIT). But
this is a good starting point.

Acked-by: Simon Glass <sjg at chromium.org>