[U-Boot] [PATCH v4] dm: sh: serial: Add support driver model

[Nobuhiro Iwamatsu]

Hi, Simon.

Thanks for your check.
I will check about this.

Best regards,
  Nobuhiro

2015-01-13 23:45 GMT+09:00 Simon Glass <sjg at chromium.org>:
> On 10 January 2015 at 10:06, Simon Glass <sjg at chromium.org> wrote:
>> Hi Nobuhiro,
>>
>> On 21 December 2014 at 21:22, Nobuhiro Iwamatsu
>> <nobuhiro.iwamatsu.yj at renesas.com> wrote:
>>> This adds driver model support with this driver. This was tested by Koelsch
>>> board and Gose board.
>>>
>>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj at renesas.com>
>>> Acked-by: Simon Glass <sjg at chromium.org>
>>> ---
>>>  V4: Fix build with SH.
>>>  V3: Add function of checking -EAGAIN without DM.
>>>  V2: Fix loop for tx fifo and tx fifo.
>>>      Fix write return code writing with DM.
>>>
>>>  drivers/serial/serial_sh.c           | 323 ++++++++++++++++++++++++-----------
>>>  drivers/serial/serial_sh.h           |  10 +-
>>>  include/dm/platform_data/serial_sh.h |  37 ++++
>>>  3 files changed, 262 insertions(+), 108 deletions(-)
>>>  create mode 100644 include/dm/platform_data/serial_sh.h
>>>
>>
>> Are you planning to bring this in through your tree or should I take
>> it through the driver model tree?
>
> Hmm I can't pick this up due to a build error:
>
> 09: dm: sh: serial: Add support driver model
>         sh: +   ap325rxa
> +../drivers/serial/serial_sh.c: In function ‘sh_serial_setbrg_generic’:
> +../drivers/serial/serial_sh.c:78:3: error: ‘sh_sci’ undeclared (first
> use in this function)
> +../drivers/serial/serial_sh.c:78:3: note: each undeclared identifier
> is reported only once for each function it appears in
>
> Regards,
> Simon



-- 
Nobuhiro Iwamatsu