[U-Boot] [RFC PATCH v2 4/9] x86: quark: Add utility codes needed for MRC

[Simon Glass]

On 5 February 2015 at 17:51, Simon Glass <sjg at chromium.org> wrote:
> Hi Bin,
>
> On 5 February 2015 at 08:42, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Add various utility codes needed for Quark MRC.
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>>
>> ---
>> There are 12 checkpatch warnings in this patch, which are:
>>
>> warning: arch/x86/cpu/quark/mrc_util.c,1446: Too many leading tabs - consider code refactoring
>> warning: arch/x86/cpu/quark/mrc_util.c,1450: line over 80 characters
>> ...
>>
>> Fixing 'Too many leading tabs ...' will be very dangerous, as I don't have
>> all the details on how Intel's MRC codes are actually written to play with
>> the hardware. Trying to refactor them may lead to a non-working MRC codes.
>> For the 'line over 80 characters' issue, we have to leave them as is now
>> due to the 'Too many leading tabs ...', sigh.
>>
>> Changes in v2:
>> - Fixed issues per review comments. See the following link for details.
>>   http://lists.denx.de/pipermail/u-boot/2015-February/204044.html
>>
>>  arch/x86/cpu/quark/hte.c      |  396 +++++++++++
>>  arch/x86/cpu/quark/hte.h      |   44 ++
>>  arch/x86/cpu/quark/mrc_util.c | 1475 +++++++++++++++++++++++++++++++++++++++++
>>  arch/x86/cpu/quark/mrc_util.h |  153 +++++
>>  4 files changed, 2068 insertions(+)
>>  create mode 100644 arch/x86/cpu/quark/hte.c
>>  create mode 100644 arch/x86/cpu/quark/hte.h
>>  create mode 100644 arch/x86/cpu/quark/mrc_util.c
>>  create mode 100644 arch/x86/cpu/quark/mrc_util.h
>
> We should revisit this with a follow-on patch to tidy this up before
> the release. I don't believe it will create correctness problems to
> split the code but that needs to be tested. Let's get this in for now
> as a stake in the ground.
>
> Acked-by: Simon Glass <sjg at chromium.org>

Applied to u-boot-x86, thanks!