[U-Boot] [PATCH v2 12/19] dm: at91: snapper: Move driver model CONFIGs to Kconfig

Masahiro Yamada yamada.m at jp.panasonic.com
Mon Feb 9 04:43:40 CET 2015


Hi Simon,

On Thu,  5 Feb 2015 21:41:43 -0700
Simon Glass <sjg at chromium.org> wrote:

> Remove driver model CONFIGs from the board config headers and use Kconfig
> instead.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
> Changes in v2: None
> 
>  arch/arm/include/asm/arch-at91/at91_pio.h | 12 ++++--------
>  configs/snapper9260_defconfig             |  3 +++
>  configs/snapper9g20_defconfig             |  3 +++
>  include/configs/snapper9260.h             |  4 ----
>  4 files changed, 10 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm/include/asm/arch-at91/at91_pio.h b/arch/arm/include/asm/arch-at91/at91_pio.h
> index 50464ff..3012278 100644
> --- a/arch/arm/include/asm/arch-at91/at91_pio.h
> +++ b/arch/arm/include/asm/arch-at91/at91_pio.h
> @@ -114,14 +114,10 @@ typedef union at91_pio {
>  		at91_port_t	pioa;
>  		at91_port_t	piob;
>  		at91_port_t	pioc;
> -	#if (ATMEL_PIO_PORTS > 3)
> -		at91_port_t	piod;
> -	#endif
> -	#if (ATMEL_PIO_PORTS > 4)
> -		at91_port_t	pioe;
> -	#endif
> -	} ;
> -	at91_port_t port[ATMEL_PIO_PORTS];
> +		at91_port_t	piod;	/* not present in all hardware */
> +		at91_port_t	pioe;/* not present in all hardware */
> +	};
> +	at91_port_t port[5];
>  } at91_pio_t;
>  
>  #ifdef CONFIG_AT91_GPIO


I could not understand why this change is
related to "Move driver model CONFIGs to Kconfig".

Nothing's mentioned about this change in your commit description.


Perhaps, split into two patches?



Best Regards
Masahiro Yamada



More information about the U-Boot mailing list