[U-Boot] [PATCH] net: keystone_net: move serdes setup to initialization function

Nishanth Menon nm at ti.com
Sun Feb 15 19:06:41 CET 2015


On 14:05-20150211, Vitaly Andrianov wrote:
> On Keystone2 devices serdes must be initialized before accessing MDIO bus.
> This commit moves the keystone2_net_serdes_setup() from keystone2_eth_open
> to keystone2_emac_initialize to meet that requirement.
> 
> This also eliminates unnecessary serdes initializatin every time when the
> keystone2_eth_open is being called.
> 
> Signed-off-by: Vitaly Andrianov <vitalya at ti.com>
> ---

Necessary for keystone 2 devices to reach to shell.

Tested-by: Nishanth Menon <nm at ti.com>

>  drivers/net/keystone_net.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/keystone_net.c b/drivers/net/keystone_net.c
> index bedab1d..35f1a57 100644
> --- a/drivers/net/keystone_net.c
> +++ b/drivers/net/keystone_net.c
> @@ -398,8 +398,6 @@ static int keystone2_eth_open(struct eth_device *dev, bd_t *bis)
>  	sys_has_mdio =
>  		(eth_priv->sgmii_link_type == SGMII_LINK_MAC_PHY) ? 1 : 0;
>  
> -	keystone2_net_serdes_setup();
> -
>  	if (sys_has_mdio)
>  		keystone2_mdio_reset(mdio_bus);
>  
> @@ -556,6 +554,8 @@ int keystone2_emac_initialize(struct eth_priv_t *eth_priv)
>  			return res;
>  	}
>  
> +	keystone2_net_serdes_setup();
> +
>  	/* Create phy device and bind it with driver */
>  #ifdef CONFIG_KSNET_MDIO_PHY_CONFIG_ENABLE
>  	phy_dev = phy_connect(mdio_bus, eth_priv->phy_addr,
> -- 
> 1.9.1
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

-- 
Regards,
Nishanth Menon


More information about the U-Boot mailing list