[U-Boot] [PATCH 1/4] mmc: fsl_esdhc: Add CMD11 support to switch to 1.8V

Otavio Salvador otavio at ossystems.com.br
Tue Feb 17 13:40:59 CET 2015


On Tue, Feb 17, 2015 at 5:11 AM, Marek Vasut <marex at denx.de> wrote:
> On Monday, February 16, 2015 at 10:38:00 PM, Otavio Salvador wrote:
>> This adds support to switch to 1.8V in case CMD11 succeeds.
>>
>> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>> ---
>
> [...]
>
>> @@ -413,6 +424,11 @@ out:
>>                       while ((esdhc_read32(&regs->sysctl) & SYSCTL_RSTD))
>>                               ;
>>               }
>> +
>> +             /* If this was CMD11, then notify that power cycle is needed */
>> +             if (cmd->cmdidx == SD_CMD_SWITCH_UHS18V)
>> +                     printf("CMD11 to switch to 1.8V mode failed."
>> +                             "Card requires power cycle\n");
>
> Please avoid breaking strings, you cannot 'git grep' for them if they're broken.

Agreed. I will prepare a v2 with this fixed.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


More information about the U-Boot mailing list