[U-Boot] [PATCH 11/14] usb: UniPhier: add UniPhier on-chip xHCI host driver support

Marek Vasut marex at denx.de
Tue Feb 17 20:51:48 CET 2015


On Tuesday, February 17, 2015 at 08:00:27 AM, Masahiro Yamada wrote:
> Support xHCI host driver used on Panasonic UniPhier platform.
> 
> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
> ---
> Hi Marek,
> 
> I want apply this patch onto u-boot-uniphier/master
> to avoid conflicts.
> 
> If you are OK with it, could you issue your Acked-by tag, please?

[...]

> +static int get_uniphier_xhci_base(int index, struct xhci_hccr **base)
> +{
> +	int offset;
> +
> +	for (offset = fdt_node_offset_by_compatible(FDT, 0, COMPAT);
> +	     offset >= 0;
> +	     offset = fdt_node_offset_by_compatible(FDT, offset, COMPAT)) {
> +		if (index == 0) {
> +			*base = (struct xhci_hccr *)
> +					fdtdec_get_addr(FDT, offset, "reg");

Hi!

does it make sense to check if the value returned by fdtdec_get_addr() is
valid here?

Otherwise,

Acked-by: Marek Vasut <marex at denx.de>

Best regards,
Marek Vasut


More information about the U-Boot mailing list