[U-Boot] [PATCH] gpt: fix error reporting on partition table write failures

Przemyslaw Marczak p.marczak at samsung.com
Wed Feb 18 18:50:03 CET 2015


Hello Rob,

On 01/26/2015 04:43 PM, Rob Herring wrote:
> The gpt command always reports success even if writing the partition table
> failed. Propagate the return value of gpt_restore so we get proper status
> reported.
>
> Signed-off-by: Rob Herring <robh at kernel.org>
> ---
>   common/cmd_gpt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/cmd_gpt.c b/common/cmd_gpt.c
> index e38422d..75df3fe 100644
> --- a/common/cmd_gpt.c
> +++ b/common/cmd_gpt.c
> @@ -281,11 +281,11 @@ static int gpt_default(block_dev_desc_t *blk_dev_desc, const char *str_part)
>   	}
>
>   	/* save partitions layout to disk */
> -	gpt_restore(blk_dev_desc, str_disk_guid, partitions, part_count);
> +	ret = gpt_restore(blk_dev_desc, str_disk_guid, partitions, part_count);
>   	free(str_disk_guid);
>   	free(partitions);
>
> -	return 0;
> +	return ret;
>   }
>
>   /**
>

This one commit, is ok.

Reviewed-by: Przemyslaw Marczak <p.marczak at samsung.com>

Best regards,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com


More information about the U-Boot mailing list