[U-Boot] [PATCH v2 6/8] kconfig: malloc: add option for skip memset at malloc init

[Simon Glass]

+Masahiro

Hi,

On 18 February 2015 at 05:40, Przemyslaw Marczak <p.marczak at samsung.com> wrote:
> Hi Simon,
>
> On 02/18/2015 05:32 AM, Simon Glass wrote:
>>
>> Hi Przemyslaw,
>>
>> On 16 February 2015 at 08:13, Przemyslaw Marczak <p.marczak at samsung.com>
>> wrote:
>>>
>>> Signed-off-by: Przemyslaw Marczak <p.marczak at samsung.com>
>>> ---
>>>   Kconfig | 26 +++++++++++++++++++-------
>>>   1 file changed, 19 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/Kconfig b/Kconfig
>>> index 4157da3..e08e44a 100644
>>> --- a/Kconfig
>>> +++ b/Kconfig
>>> @@ -57,13 +57,25 @@ config CC_OPTIMIZE_FOR_SIZE
>>>            This option is enabled by default for U-Boot.
>>
>>
>> Ah, you have done this. Then I think you can merge this patch with the
>> dlmalloc patch and drop the README one.
>>
>
> Shouldn't we keep both, README and Kconfig help?
> Kconfig is just a configuration tool, README is a documentation.
> Sometimes it could be faster to find something in the text instead of
> config.

Agreed, but isn't it going to be a pain to add it in both places and
keep it in sync? Maybe we could create a script which creates a
README.kconfig containing all the options and help.

>
>
>>>
>>>   menuconfig EXPERT
>>> -        bool "Configure standard U-Boot features (expert users)"
>>> -        help
>>> -          This option allows certain base U-Boot options and settings
>>> -          to be disabled or tweaked. This is for specialized
>>> -          environments which can tolerate a "non-standard" U-Boot.
>>> -          Only use this if you really know what you are doing.
>>> -
>>> +       bool "Configure standard U-Boot features (expert users)"
>>> +       help
>>> +         This option allows certain base U-Boot options and settings
>>> +         to be disabled or tweaked. This is for specialized
>>> +         environments which can tolerate a "non-standard" U-Boot.
>>> +         Only use this if you really know what you are doing.
>>> +
>>> +if EXPERT
>>> +       config SYS_MALLOC_INIT_SKIP_ZEROING
>>> +       bool "Skip memset at malloc init (reduce boot time)"
>>> +       help
>>> +        This avoids zeroing memory reserved for malloc at malloc init.
>>> +        Significant boot time reduction is visible for configs in which
>>> +        CONFIG_SYS_MALLOC_LEN value, has more than few MiB.
>>> +        Useful for bzip2, bmp logo.
>>> +        Warning:
>>> +        When enable, make sure that calloc() is used when zeroed
>>> +        memory is needed.
>>> +endif
>>>   endmenu                # General setup
>>>
>>>   menu "Boot images"

Regards,
Simon