[U-Boot] [PATCH 1/6] sandbox: only do sandboxfs for hostfs interface

Simon Glass sjg at chromium.org
Fri Feb 20 20:22:58 CET 2015


Hi Sjoerd,

On 19 February 2015 at 15:41, Sjoerd Simons
<sjoerd.simons at collabora.co.uk> wrote:
> Only do sandbox filesystem access when using the hostfs device
> interface, rather then falling back to it in all cases. This prevents
> confusion situations due to the fallback being taken rather then an
> unsupported error being raised.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons at collabora.co.uk>

Reviewed-by: Simon Glass <sjg at chromium.org>

See nit below.

> ---
>  fs/sandbox/sandboxfs.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/fs/sandbox/sandboxfs.c b/fs/sandbox/sandboxfs.c
> index a920bc0..c6540c6 100644
> --- a/fs/sandbox/sandboxfs.c
> +++ b/fs/sandbox/sandboxfs.c
> @@ -10,7 +10,10 @@
>
>  int sandbox_fs_set_blk_dev(block_dev_desc_t *rbdd, disk_partition_t *info)
>  {
> -       return 0;
> +       /* Only accept a NULL block_dev_desc_t for the sandbox, which is when

/*
 * Only accept

> +        * hostfs interface is used
> +        */
> +       return rbdd != NULL;
>  }
>
>  int sandbox_fs_read_at(const char *filename, loff_t pos, void *buffer,
> --
> 2.1.4
>

Regards,
Simon


More information about the U-Boot mailing list