[U-Boot] [PATCH 2/2] usb: invoke board specific USB cleanup interface

[Rob Herring]

On Mon, Jan 19, 2015 at 1:07 AM, Inha Song <ideal.song at samsung.com> wrote:
> This patch invoke board-specific USB cleanup (board_usb_cleanup)
> interface.
>
> Signed-off-by: Inha Song <ideal.song at samsung.com>
> ---
>  common/cmd_dfu.c              | 1 +
>  common/cmd_thordown.c         | 1 +
>  common/cmd_usb_mass_storage.c | 1 +

You missed fastboot at a minimum.

What about other gadget functions such as rndis/cdc_etherent?

>  3 files changed, 3 insertions(+)
>
> diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c
> index e975abe..161d38b 100644
> --- a/common/cmd_dfu.c
> +++ b/common/cmd_dfu.c
> @@ -68,6 +68,7 @@ static int do_dfu(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>         }
>  exit:
>         g_dnl_unregister();
> +       board_usb_cleanup(controller_index, USB_INIT_DEVICE);

Perhaps this should be part of g_dnl_unregister since it is always
called immediately after.

>  done:
>         dfu_free_entities();
>
> diff --git a/common/cmd_thordown.c b/common/cmd_thordown.c
> index 8ed1dc6..436b7f5 100644
> --- a/common/cmd_thordown.c
> +++ b/common/cmd_thordown.c
> @@ -56,6 +56,7 @@ int do_thor_down(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>
>  exit:
>         g_dnl_unregister();
> +       board_usb_cleanup(controller_index, USB_INIT_DEVICE);
>  done:
>         dfu_free_entities();
>
> diff --git a/common/cmd_usb_mass_storage.c b/common/cmd_usb_mass_storage.c
> index 2c879ea..53a765e 100644
> --- a/common/cmd_usb_mass_storage.c
> +++ b/common/cmd_usb_mass_storage.c
> @@ -154,6 +154,7 @@ int do_usb_mass_storage(cmd_tbl_t *cmdtp, int flag,
>         }
>  exit:
>         g_dnl_unregister();
> +       board_usb_cleanup(controller_index, USB_INIT_DEVICE);
>         return CMD_RET_SUCCESS;
>  }
>
> --
> 2.0.0.390.gcb682f8
>