[U-Boot] unassigned-patches/132: Re: [PATCH] x86: minnowmax: add GPIO mapping support

[u-boot at bugs.denx.de]

Hi Gabriel,

On Mon, Feb 16, 2015 at 5:55 AM, Gabriel Huau <contact at huau-gabriel.fr> wrote:
> Configure the pinctrl as it required to make some IO controllers
> working (USB/UART/I2C/...).
> The idea would be in the next version to modify the pch GPIO driver and
> configure these pins through the device tree.
>
> These modifications are ported from the coreboot project.
>
> Signed-off-by: Gabriel Huau <contact at huau-gabriel.fr>
> ---
>  arch/x86/cpu/baytrail/Makefile                |   1 +
>  arch/x86/cpu/baytrail/gpio.c                  | 206 +++++++++++++++
>  arch/x86/include/asm/arch-baytrail/gpio.h     | 364 ++++++++++++++++++++++++++
>  arch/x86/include/asm/arch-baytrail/iomap.h    |  73 ++++++
>  arch/x86/include/asm/arch-baytrail/irq.h      | 119 +++++++++
>  arch/x86/include/asm/arch-baytrail/irqroute.h |  67 +++++
>  arch/x86/include/asm/arch-baytrail/pci_devs.h | 144 ++++++++++
>  arch/x86/include/asm/arch-baytrail/pmc.h      | 253 ++++++++++++++++++
>  board/intel/minnowmax/minnowmax.c             | 212 +++++++++++++++
>  include/configs/minnowmax.h                   |  11 +
>  10 files changed, 1450 insertions(+)
>  create mode 100644 arch/x86/cpu/baytrail/gpio.c
>  create mode 100644 arch/x86/include/asm/arch-baytrail/iomap.h
>  create mode 100644 arch/x86/include/asm/arch-baytrail/irq.h
>  create mode 100644 arch/x86/include/asm/arch-baytrail/irqroute.h
>  create mode 100644 arch/x86/include/asm/arch-baytrail/pci_devs.h
>  create mode 100644 arch/x86/include/asm/arch-baytrail/pmc.h
>

[snip]

> diff --git a/include/configs/minnowmax.h b/include/configs/minnowmax.h
> index 823e051..738c6fa 100644
> --- a/include/configs/minnowmax.h
> +++ b/include/configs/minnowmax.h
> @@ -69,4 +69,15 @@
>  /* Avoid a warning in the Realtek Ethernet driver */
>  #define CONFIG_SYS_CACHELINE_SIZE 16
>
> +/*
> + * Baytrail has 3 GPIOs bank over PCI, there is no
> + * driver at the moment so let's disable the command
> + * and the default x86 driver to avoid any collision
> + * with the GPIO mapping code.
> + * @TODO: adding a baytrail-gpio driver and configure
> + * the muxing through the device tree
> + */
> +#undef CONFIG_INTEL_ICH6_GPIO
> +#undef CONFIG_CMD_GPIO
> +

Why undef these two? The BayTrail SoC does support GPIO banks in the
legacy bridge.

>  #endif /* __CONFIG_H */
> --

Regards,
Bin

---
Added to GNATS database as unassigned-patches/132
>Responsible:    patch-coord
>Message-Id:     <CAEUhbmVRSwmt8HnW445a2kLzE12dmZcgJ+_Y7uj0u6uqvS=_7g at mail.gmail.com>
>In-Reply-To:    <1424037328-31636-1-git-send-email-contact at huau-gabriel.fr>
>References:     <1424037328-31636-1-git-send-email-contact at huau-gabriel.fr>
>Patch-Date:     Wed Feb 25 08:52:14 +0100 2015