[U-Boot] [PATCH 2/2] usb: invoke board specific USB cleanup interface

[Tom Rini]

On Wed, Feb 25, 2015 at 06:58:03PM +0900, Inha Song wrote:
> Hi, Rob,
> 
> 
> On Tue, 24 Feb 2015 10:20:13 -0600
> Rob Herring <robh at kernel.org> wrote:
> 
> > On Mon, Jan 19, 2015 at 1:07 AM, Inha Song <ideal.song at samsung.com> wrote:
> > > This patch invoke board-specific USB cleanup (board_usb_cleanup)
> > > interface.
> > >
> > > Signed-off-by: Inha Song <ideal.song at samsung.com>
> > > ---
> > >  common/cmd_dfu.c              | 1 +
> > >  common/cmd_thordown.c         | 1 +
> > >  common/cmd_usb_mass_storage.c | 1 +
> > 
> > You missed fastboot at a minimum.
> 
> Ok, I will add board_usb_cleanup fuction also in fastboot.
> 
> > 
> > What about other gadget functions such as rndis/cdc_etherent?
> 
> I doesn't have any knowledge about rndis/cdc_etherent
> So, Afraid that to fix these code.

So that's the problem with this approach.  Kishon reminded me that on TI
parts we see some PM problems because we don't always do a cleanup on
the USB side for gadgets.  I think the right answer here is to mirror
the usb_stop() function in bootm_disable_interrupts() in common/bootm.c
for the gadget code as well.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150225/ea95d866/attachment.sig>