[U-Boot] unassigned-patches/134: Re: [PATCH] x86: minnowmax: add GPIO mapping support

[u-boot at bugs.denx.de]

Hi Bin,

On 02/24/2015 11:52 PM, Bin Meng wrote:
> Hi Gabriel,
>
> On Mon, Feb 16, 2015 at 5:55 AM, Gabriel Huau <contact at huau-gabriel.fr> wrote:
>> Configure the pinctrl as it required to make some IO controllers
>> working (USB/UART/I2C/...).
>> The idea would be in the next version to modify the pch GPIO driver and
>> configure these pins through the device tree.
>>
>> These modifications are ported from the coreboot project.
>>
>> Signed-off-by: Gabriel Huau <contact at huau-gabriel.fr>
>> ---
>>   arch/x86/cpu/baytrail/Makefile                |   1 +
>>   arch/x86/cpu/baytrail/gpio.c                  | 206 +++++++++++++++
>>   arch/x86/include/asm/arch-baytrail/gpio.h     | 364 ++++++++++++++++++++++++++
>>   arch/x86/include/asm/arch-baytrail/iomap.h    |  73 ++++++
>>   arch/x86/include/asm/arch-baytrail/irq.h      | 119 +++++++++
>>   arch/x86/include/asm/arch-baytrail/irqroute.h |  67 +++++
>>   arch/x86/include/asm/arch-baytrail/pci_devs.h | 144 ++++++++++
>>   arch/x86/include/asm/arch-baytrail/pmc.h      | 253 ++++++++++++++++++
>>   board/intel/minnowmax/minnowmax.c             | 212 +++++++++++++++
>>   include/configs/minnowmax.h                   |  11 +
>>   10 files changed, 1450 insertions(+)
>>   create mode 100644 arch/x86/cpu/baytrail/gpio.c
>>   create mode 100644 arch/x86/include/asm/arch-baytrail/iomap.h
>>   create mode 100644 arch/x86/include/asm/arch-baytrail/irq.h
>>   create mode 100644 arch/x86/include/asm/arch-baytrail/irqroute.h
>>   create mode 100644 arch/x86/include/asm/arch-baytrail/pci_devs.h
>>   create mode 100644 arch/x86/include/asm/arch-baytrail/pmc.h
>>
> [snip]
>
>> diff --git a/include/configs/minnowmax.h b/include/configs/minnowmax.h
>> index 823e051..738c6fa 100644
>> --- a/include/configs/minnowmax.h
>> +++ b/include/configs/minnowmax.h
>> @@ -69,4 +69,15 @@
>>   /* Avoid a warning in the Realtek Ethernet driver */
>>   #define CONFIG_SYS_CACHELINE_SIZE 16
>>
>> +/*
>> + * Baytrail has 3 GPIOs bank over PCI, there is no
>> + * driver at the moment so let's disable the command
>> + * and the default x86 driver to avoid any collision
>> + * with the GPIO mapping code.
>> + * @TODO: adding a baytrail-gpio driver and configure
>> + * the muxing through the device tree
>> + */
>> +#undef CONFIG_INTEL_ICH6_GPIO
>> +#undef CONFIG_CMD_GPIO
>> +
> Why undef these two? The BayTrail SoC does support GPIO banks in the
> legacy bridge.
I might misunderstood the GPIO subsystem but I thought there was 2 banks
available through the PCU iLB GPIO controller which contains the SCORE
and SSUS (102 / 44 pins).
The intel_ich6_gpio has a limitation of 32 GPIOs per bank and I thought
it was just a different controller from the Baytrail, but if I can use
it to control all the GPIOs + doing the IO mapping, I'll be glad to do it!

>
>>   #endif /* __CONFIG_H */
>> --
> Regards,
> Bin
Regards,
Gabriel

---
Added to GNATS database as unassigned-patches/134
>Responsible:    patch-coord
>Message-Id:     <54EDF800.8060907 at huau-gabriel.fr>
>In-Reply-To:    <CAEUhbmVRSwmt8HnW445a2kLzE12dmZcgJ+_Y7uj0u6uqvS=_7g at mail.gmail.com>
>References:     <1424037328-31636-1-git-send-email-contact at huau-gabriel.fr> <CAEUhbmVRSwmt8HnW445a2kLzE12dmZcgJ+_Y7uj0u6uqvS=_7g at mail.gmail.com>
>Patch-Date:     Wed Feb 25 17:27:44 +0100 2015