[U-Boot] [PATCH v1 1/1] fastboot: Update getvar command to get 'userdata' partition size

[Rob Herring]

On Wed, Feb 25, 2015 at 3:45 PM, Dileep Katta <dileep.katta at linaro.org> wrote:
> Hi Rob,
>
>
> On 20 February 2015 at 20:24, Rob Herring <rob.herring at linaro.org> wrote:
>>
>> On Wed, Feb 18, 2015 at 1:52 PM, Dileep Katta <dileep.katta at linaro.org>
>> wrote:
>> > This patch adds functionality to getvar command to get the userdata
>> > partition
>> > size.
>>
>> This is non-standard and doesn't scale to other partitions. There is
>
>
> Is there a way to add support for retrieving some non-standard variables,
> such as cpu_type or
> board specific information in getvar or other command(oem!) in fastboot?

That is what my patch does. You just have to create the env variable
on your board.

>> already a standard var "partition-size:<part name>". There is also
>> "partition-type:<part name>" which probably needs to be supported as
>> well. It would probably be good to have generic code to retrieve
>> fastboot variables from a u-boot environment variables. Something like
>> this:
>>
>>     fastboot: allow retrieving fastboot variables from env
>>
>>     Signed-off-by: Rob Herring <robh at kernel.org>
>>
> Thanks for the suggestion.
> Is it fine to extend fb_mmc_get_ptn_size() in this patch to to support
> standard var "partition-size:<part name>"
> and similar functionality for partition-type?

That's probably ok, but it would not work on an un-formatted device
(perhaps that is okay).

Also, I'd rather not see more MMC specific code. Soon as I want to
support a device with SATA, then we've got to go generalize
everything.

> or using "mtdparts" environment variable to get partition-type or
> partition-size is preferable? Please advise.

The partitioning/formatting code needs to know the sizes of
partitions, so keeping them in env vars could be reused by both.

Rob