[U-Boot] [PATCH] arm64: Add Xilinx ZynqMP support

[Tom Rini]

On Tue, Feb 24, 2015 at 09:02:09AM +0100, Michal Simek wrote:

> Add basic Xilinx ZynqMP arm64 support.
> Serial and SD is supported.
> It supports emulation platfrom ep108 and QEMU.
> 
> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
[snip]
> +/* Miscellaneous configurable options */
> +#define CONFIG_SYS_LOAD_ADDR		0x8000000
> +
> +/* Initial environment variables */
> +#define CONFIG_EXTRA_ENV_SETTINGS \
> +	"ethaddr=00:0a:35:00:01:22\0" \

No, you can't hard-code an ethaddr in.

> +	"kernel_addr=0x200000\0" \
> +	"initrd_addr=0xa00000\0" \
> +	"initrd_size=0x2000000\0" \

These are really close together.  And I imagine mirror the usual values
on 32bit platforms.  Maybe it's time to move them around a bit for more
space?

> +	"fdt_addr=0x100000\0" \
> +	"fdt_high=0x10000000\0" \

We also shouldn't have to play "stop relocating the DT" games on
aarch64, right?  Since all memory is visible and that's why we have to
do those games on aarch32.

> +	"sdboot=mmcinfo && fatload mmc 0:0 f000000 system.dtb && " \
> +		"fatload mmc 0:0 f000000 Image && booti 80000 - f000000\0"

You aren't using $fdt_addr/$kernel_addr here and probably should?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150227/928ffc58/attachment.sig>