[U-Boot] [PATCHv1 02/22] arm: socfpga: enable saveenv to mmc partition

[Marek Vasut]

On Wednesday, January 14, 2015 at 05:40:42 PM, dinguyen at opensource.altera.com 
wrote:
> From: Dinh Nguyen <dinguyen at opensource.altera.com>
> 
> Signed-off-by: Dinh Nguyen <dinguyen at opensource.altera.com>
> Cc: Marek Vasut <marex at denx.de>
> Cc: Tom Rini <trini at ti.com>
> Cc: Pavel Machek <pavel at denx.de>
> ---
>  include/configs/socfpga_common.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/include/configs/socfpga_common.h
> b/include/configs/socfpga_common.h index 6b1f967..673377b 100644
> --- a/include/configs/socfpga_common.h
> +++ b/include/configs/socfpga_common.h
> @@ -281,9 +281,12 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
>  #define CONFIG_SYS_CONSOLE_IS_IN_ENV
>  #define CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE
>  #define CONFIG_SYS_CONSOLE_ENV_OVERWRITE
> -#define CONFIG_ENV_IS_NOWHERE
>  #define CONFIG_ENV_SIZE			4096
> 
> +#define CONFIG_ENV_IS_IN_MMC
> +#define CONFIG_SYS_MMC_ENV_DEV		0/* device 0 */

Hi!

Please at least put a TAB between the number and the comment, so that the
code looks tidy and readable.

It would also be nice to split the SPL stuff and "generic" stuff into separate 
patch (series), since this would allow generic stuff like this patch to go in
first.

Thanks!

Best regards,
Marek Vasut