[U-Boot] [PATCHv1 02/22] arm: socfpga: enable saveenv to mmc partition

[Pavel Machek]

Hi!

> From: Dinh Nguyen <dinguyen at opensource.altera.com>
> 
> Signed-off-by: Dinh Nguyen <dinguyen at opensource.altera.com>
> Cc: Marek Vasut <marex at denx.de>
> Cc: Tom Rini <trini at ti.com>
> Cc: Pavel Machek <pavel at denx.de>
> ---
>  include/configs/socfpga_common.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h
> index 6b1f967..673377b 100644
> --- a/include/configs/socfpga_common.h
> +++ b/include/configs/socfpga_common.h
> @@ -281,9 +281,12 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
>  #define CONFIG_SYS_CONSOLE_IS_IN_ENV
>  #define CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE
>  #define CONFIG_SYS_CONSOLE_ENV_OVERWRITE
> -#define CONFIG_ENV_IS_NOWHERE
>  #define CONFIG_ENV_SIZE			4096
>  
> +#define CONFIG_ENV_IS_IN_MMC
> +#define CONFIG_SYS_MMC_ENV_DEV		0/* device 0 */
> +#define CONFIG_ENV_OFFSET		512/* just after the MBR */
> +

Would it make sense to make environment bigger (64K?) at this point,
and enabling the redundant environment option, so that one bad block
does not bring the whole device down?

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html