[U-Boot] [PATCH 2/6] dm: pci: Correct primary/secondary/subordinate bus number assignment

Simon Glass sjg at chromium.org
Mon Jul 20 03:59:29 CEST 2015


Hi Bin,

On 18 July 2015 at 10:20, Bin Meng <bmeng.cn at gmail.com> wrote:
> In driver model, each pci bridge device has its own hose structure.
> hose->first_busno points to the bridge device's device number, so
> we should not substract hose->first_busno before programming the
> bridge device's primary/secondary/subordinate bus number registers.
>
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> ---
>
>  drivers/pci/pci_auto.c | 9 +++++++++
>  1 file changed, 9 insertions(+)

Acked-by: Simon Glass <sjg at chromium.org>
Tested-by: Simon Glass <sjg at chromium.org>

I'm not happy with how each PCI bridge has its own hose structure. I
think that was a mistake. It just creates problems.

I'm thinking we should instead have a UCLASS_PCI which is strictly for
the PCI controller, and a new UCLASS_PCI_BRIDGE for bridges.

What do you think?

Regards,
Simon


More information about the U-Boot mailing list