[U-Boot] [PATCH V3 4/8] configs: ti_armv7_keystone2: start using armv7_common

Murali Karicheri m-karicheri2 at ti.com
Wed Jul 22 17:19:29 CEST 2015


On 07/18/2015 12:40 PM, Nishanth Menon wrote:
> Try to maintain as much commonality by conditionally including stuff
> in armv7_common as necessary and removing the common defines from
> keystone2 header.

>
>   /* U-Boot Build Configuration */
>   #define CONFIG_SKIP_LOWLEVEL_INIT	/* U-Boot is a 2nd stage loader */
> -#define CONFIG_SYS_NO_FLASH		/* that is, no *NOR* flash */
> -#define CONFIG_SYS_CONSOLE_INFO_QUIET
>   #define CONFIG_BOARD_EARLY_INIT_F
> -#define CONFIG_SYS_THUMB_BUILD

One thing I see is THUMB build is only enabled for SPL build in 
ti_armv7_common.h. With this transition, regular build will not be using 
THUMB build anymore.  This is not right. Please fix it. Many platforms 
configs such as tbs2910.h, colibri_vf.h, highbank.h etc has this enabled 
for both builds as this will reduce the image size.

>
>   /* SoC Configuration */

-- 
Murali Karicheri
Linux Kernel, Keystone


More information about the U-Boot mailing list